Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Darwin ARM64 binaries #1594

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Added Darwin ARM64 binaries #1594

merged 1 commit into from
Sep 15, 2022

Conversation

daniellockyer
Copy link
Member

@daniellockyer daniellockyer commented Apr 27, 2022

Please see this comment:

Hey all! 👋🏻 Whilst I would love to merge this, the generated binaries it produces get caught up with MacOS' quarantine flag, so the it requires you to remove the flag in order for it to be run, which is clearly not going to work from an end-user perspective.

I can't tell if it's something I'm doing locally or whether there is some security issue I've missed.

Any ideas welcome 🙂

@daniellockyer daniellockyer self-assigned this Apr 27, 2022
@daniellockyer daniellockyer force-pushed the arm64-test branch 20 times, most recently from 3bfe330 to e145caa Compare April 28, 2022 08:05
@daniellockyer daniellockyer force-pushed the arm64-test branch 4 times, most recently from 376637a to 832950b Compare May 19, 2022 17:37
@daniellockyer daniellockyer changed the title WIP: added Darwin arm64 binaries Added Darwin ARM64 binaries May 19, 2022
@adrian-arapiles
Copy link

Any update about that? It's seems one test failed because connection issues.
Really appreciated this could be released if it's working.
Thanks.

@gjsjohnmurray
Copy link

@daniellockyer please can we also have the binary for Node v14? That is the version currently used by the mtxr/sqltools project which led me here.

@daniellockyer
Copy link
Member Author

@gjsjohnmurray The binaries only vary on the Node-API version they're built against: https://nodejs.org/api/n-api.html#node-api-version-matrix. We support v3 and v6 right now. If you've got an ARM64 build of Node 14, it should work 🙂

atulsmadhugiri added a commit to CommE2E/comm that referenced this pull request Oct 18, 2022
Summary:
`@redux-devtools/cli` is dependent on the `sqlite3` node package (https://github.com/TryGhost/node-sqlite3). There previously weren't aarch64 binaries available, so `sqlite3` had to be built from scratch which made `yarn cleaninstall` take a while.

They recently added prebuilt binaries (TryGhost/node-sqlite3#1594), so we should bump the version to take advantage of this.

On my machine this took `yarn cleaninstall` from ~90 seconds to under a minute (~58 seconds).

Test Plan:
Read through release notes and things should continue to work as expected.

NOTE: This is unrelated to the SQLite client DB we use in the `native` app. This SQLite is solely to power Redux dev tools (which still work as expected).

Reviewers: tomek, marcin, ginsu, rohan, varun, ashoat

Reviewed By: ashoat

Subscribers: abosh

Differential Revision: https://phab.comm.dev/D5385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants