-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Darwin ARM64 binaries #1594
Conversation
3bfe330
to
e145caa
Compare
e145caa
to
0dedf4a
Compare
376637a
to
832950b
Compare
Any update about that? It's seems one test failed because connection issues. |
@daniellockyer please can we also have the binary for Node v14? That is the version currently used by the mtxr/sqltools project which led me here. |
@gjsjohnmurray The binaries only vary on the Node-API version they're built against: https://nodejs.org/api/n-api.html#node-api-version-matrix. We support v3 and v6 right now. If you've got an ARM64 build of Node 14, it should work 🙂 |
Summary: `@redux-devtools/cli` is dependent on the `sqlite3` node package (https://github.com/TryGhost/node-sqlite3). There previously weren't aarch64 binaries available, so `sqlite3` had to be built from scratch which made `yarn cleaninstall` take a while. They recently added prebuilt binaries (TryGhost/node-sqlite3#1594), so we should bump the version to take advantage of this. On my machine this took `yarn cleaninstall` from ~90 seconds to under a minute (~58 seconds). Test Plan: Read through release notes and things should continue to work as expected. NOTE: This is unrelated to the SQLite client DB we use in the `native` app. This SQLite is solely to power Redux dev tools (which still work as expected). Reviewers: tomek, marcin, ginsu, rohan, varun, ashoat Reviewed By: ashoat Subscribers: abosh Differential Revision: https://phab.comm.dev/D5385
Please see this comment: